-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate APNG into show and save methods #16650
Comments
Branch: u/gagern/ticket/16650 |
comment:3
Only the last commit is really new. The merge before that did resolve a conflict, but in a pretty obvious way. Everything else is from the named dependencies. Last 10 new commits:
|
Commit: |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:8
The recent changes from #17234 prevent our dependency #7298 from being merged, and at the moment I'm far from sure how to rebase that code, see #7298 comment:48. Once I get that rebased, there is one question regarding this ticket here as well: Should we reuse the PNG format description, or introduce a new one? On the one hand, APNG (as opposed to MNG) is very much about graceful degradation, so it makes sense to treat it as PNG in most places. On the other hand, perhaps the display manager can decide whether a client is actually capable of displaying APNG or not. If so, we might prefer supported APNG over GIF, but GIF over unsupported APNG interpreted as still PNG. If the display manager does not know about APNG support, but does know that PNG is supported, then the user should at least be able to choose APNG format manually, even though it might not be the auto-selected default in that case. |
comment:9
Do not reuse Another basic output format should be a sequence of PNG, which can easily be displayed in a web browser with javascript (embed images as necessary). Perhaps the easiest animation format. |
comment:10
Replying to @vbraun:
I'm not sure how much such a format would suffer from HTTP overhead, particularly for a large number of small frames. I guess it depends on the network connection (for the cloud in particular) whether that factor outweights the overhead of concatenating all PNGs to a single APNG file. But if you are willing to use custom JavaScript code for animations, you could also use existing code which provides APNG support on browsers which don't support it natively. |
comment:11
I'm thinking about base64-encoded inline images, especially since IPython doesn't allow you to return arbitrary collections of files. Though an apng polyfill would work, too. |
comment:12
I intend not to work on this until #7298 gets reviewed and ready for merge. |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:15
Since #7298 received a positive review just now, here is a rebased version of this modification here. With the new rich representations framework, there was a lot more to do than in the original commits. But it integrates APNG nicely with all the rest. |
comment:16
does not apply |
Once #16571 and #7298 get merged, it is time to add support for animapted PNGs (APNG) to the
Animation.show()
andAnimation.save()
methods, and also to update the doctests to useshow(format="png")
for these.Depends on #7298
Depends on #16571
CC: @nilesjohnson
Component: graphics
Keywords: notebook, animate
Author: Martin von Gagern
Branch/Commit: u/gagern/ticket/16650 @
6c6eee3
Issue created by migration from https://trac.sagemath.org/ticket/16650
The text was updated successfully, but these errors were encountered: