Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev scripts can not handle merged tickets #16124

Closed
saraedum opened this issue Apr 10, 2014 · 9 comments
Closed

dev scripts can not handle merged tickets #16124

saraedum opened this issue Apr 10, 2014 · 9 comments

Comments

@saraedum
Copy link
Member

Merging dependencies fails when one of the tickets has already been merged. In
this case the branch field of the ticket does not contain an actual branch but
a commit hash.

CC: @miguelmarco

Component: misc

Author: Julian Rueth

Branch/Commit: 22e0a10

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/16124

@saraedum saraedum added this to the sage-6.2 milestone Apr 10, 2014
@saraedum
Copy link
Member Author

Branch: u/saraedum/ticket/16124

@vbraun
Copy link
Member

vbraun commented Apr 14, 2014

comment:3

It is an intentional feature that you cannot download arbitrary commits (define by SHA1) from remote git servers. Only named branches can be fetched.


New commits:

22e0a10Handle already merged tickets correctly when merging dependencies in the dev scripts.

@vbraun
Copy link
Member

vbraun commented Apr 14, 2014

Commit: 22e0a10

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@rwst
Copy link
Contributor

rwst commented Dec 27, 2014

comment:6

wontfix because of removal of dev scripts, see https://groups.google.com/forum/?hl=en#!topic/sage-devel/JtVWAdvw-3A

@rwst rwst removed this from the sage-6.4 milestone Dec 27, 2014
@saraedum
Copy link
Member Author

comment:7

I hope you don't mind that I revert your change. But I do not think that the discussion about the dev scripts removal has reached a conclusion yet.

@saraedum saraedum added this to the sage-6.5 milestone Dec 27, 2014
@vbraun
Copy link
Member

vbraun commented Jun 19, 2015

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Jun 19, 2015

comment:8

Fine with me if you manage to fill in the author name...

@jdemeyer
Copy link
Contributor

Author: Julian Rueth

@vbraun
Copy link
Member

vbraun commented Jul 15, 2015

Changed branch from u/saraedum/ticket/16124 to 22e0a10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants