-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta-ticket for Python 3.6+ preparation (sage library) - stage 1 #15980
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:4
Hi Wilfried, There is currently a meta-ticket pertaining to supporting Python 3.3 for the Sage distribution, which includes making various changes to the build system and upgrading various dependencies (see #15530). I've added this meta-ticket to that meta-ticket and changed the summary of this one to better reflect that it is specifically referring to the sage library. I'm a little confused on your distinction between stage 1 and stage 2. What exactly are things that go into stage 2 but not into stage 1? I don't see anywhere in this list issues with renamed/reorganized libraries like urllib or StringIO, maybe this is part of the compatibility library that you mention as part of stage 2? Also, probably the biggest issue with Python 3 support is the requirement for rich comparison, which again wasn't mentioned in here. |
comment:5
Hi Andrew, Thanks for linking the ticket:15530 and improving the ticket's title. As for stage 2 I guess I should soon open the respective meta-ticket. Some reasons for assigning tasks to stage 2:
And yes, the issues to mention belong to stage 2. Hopefully the tasks assigned to stage 1 turn out (relatively) easy :-) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:8
Was changed to "needs review" to allow "needs work". |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:12
Changed No. 10 (ticket:16067) and No. 37 (ticket:16078) from stage 2 to stage 1. Corrected the fixer name in No. 50 to "xreadlines". |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:30
Can this be closed? |
comment:31
ok, let us close this one too. |
For progress on making all doctests pass, see #26212
This ticket tracks a number of other tickets that relate to various tasks to prepare Sage code for Python 3.
The following table lists those fixers from 2to3 that are applicable for stage 1.
//stage 1// includes those 2to3 fixers that produce code which can run on Python 2.7 (possibly using some from
__future__
import ... or from future_builtins import ...). The code will usually not run on Python 3.//stage 2// has those 2to3 fixers (and possibly others) that produce code which can run on Python 3 (more precisely Python 3.3+). The code can run on Python 2 only with the support of imported "compatibility" libraries. Stage 2 is now meta-ticket #16052.
After completion of stage 1 and 2 Sage should have a single, common code base for Python 2.7 and Python 3.3+.
from `future` import xxx
from `future` import absolute_import
from `future` import print_function
The following changes do not relate to 2to3:
from `future` import division
lib2to3/fixes/*
.lib2to3/fixes/*
.Component: python3
Issue created by migration from https://trac.sagemath.org/ticket/15980
The text was updated successfully, but these errors were encountered: