Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement right-angled Artin groups #15137

Closed
tscrim opened this issue Sep 1, 2013 · 45 comments
Closed

Implement right-angled Artin groups #15137

tscrim opened this issue Sep 1, 2013 · 45 comments

Comments

@tscrim
Copy link
Collaborator

tscrim commented Sep 1, 2013

This patch implements Right-angled Artin groups (RAAG's for short, a.k.a. graph groups or partially commutative groups).

Depends on #15603
Depends on #15669

CC: @vbraun @miguelmarco

Component: group theory

Keywords: Artin group RAAG, days54, sd58

Author: Travis Scrimshaw

Branch/Commit: 473384d

Reviewer: Frédéric Chapoton, Miguel Marco

Issue created by migration from https://trac.sagemath.org/ticket/15137

@tscrim tscrim added this to the sage-6.1 milestone Sep 1, 2013
@tscrim tscrim self-assigned this Sep 1, 2013
@tscrim
Copy link
Collaborator Author

tscrim commented Sep 1, 2013

comment:1

There is a TODO in that there isn't a good way to create a matrix over ZZ union oo. By default, it coerces into the infinity ring, and explicitly working over the symbolic ring, I couldn't get the equals check to work. I think we'd need a ring for a base ring union infinity as a default coercion.

@hughrthomas
Copy link

comment:2

Hi Travis--

It's a bit of a hack, but what about using -1 for infinity in the Coxeter matrix?

cheers,

Hugh

@tscrim

This comment has been minimized.

@tscrim
Copy link
Collaborator Author

tscrim commented Sep 10, 2013

comment:3

That's a good idea. It has been done.

@fchapoton
Copy link
Contributor

comment:4

Would it be possible to replace the symbolic ring (awful thing in my opinion) by the universal cyclotomic field (see my addon patch in #14816) ?

And how do you interact with #14816 (and also with #9290) ?

@tscrim
Copy link
Collaborator Author

tscrim commented Sep 10, 2013

comment:5

Replying to @fchapoton:

Would it be possible to replace the symbolic ring (awful thing in my opinion) by the universal cyclotomic field (see my addon patch in #14816) ?

I don't like the symbolic ring either, but I wan't quite sure before about how to make it work with the UCF. I'm thinking we could peel off the necessary portion of your addon patch in #14816 and put it with the Coxeter group code.

And how do you interact with #14816 (and also with #9290) ?

I didn't notice #9290, so shall we move the Coxeter group code there? I also haven't thought completely through yet how I want to interact with #14816 and Weyl groups of root systems.

@tscrim

This comment has been minimized.

@tscrim
Copy link
Collaborator Author

tscrim commented Sep 11, 2013

comment:6

I've split off the Coxeter portion to #9290 since that ticket already is for that. This ticket now focuses solely on a first implementation of RAAG's.

@tscrim
Copy link
Collaborator Author

tscrim commented Sep 11, 2013

Changed keywords from Coxeter Artin group RAAG to Artin group RAAG

@tscrim tscrim changed the title Implement general Coxeter groups and RAAGs Implement right-angled Artin groups Sep 11, 2013
@tscrim
Copy link
Collaborator Author

tscrim commented Nov 7, 2013

Commit: e8de01f

@tscrim
Copy link
Collaborator Author

tscrim commented Nov 7, 2013

comment:7

Attachment: trac_15137-groups-ts.patch.gz

New commits:

[e8de01f](https://github.com/sagemath/sagetrac-mirror/commit/e8de01f)#15137: Implement right-angled Artin groups and general Coxeter groups.

@tscrim
Copy link
Collaborator Author

tscrim commented Nov 7, 2013

Branch: public/groups/15137-raags

@tscrim
Copy link
Collaborator Author

tscrim commented Nov 9, 2013

Changed keywords from Artin group RAAG to Artin group RAAG, days54

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

4d5091eMerge branch 'public/groups/15137-raags' of trac.sagemath.org:sage into public/groups/15137-raags
0f6f1b4Changed to use new immutable graph backend.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2014

Changed commit from e8de01f to 0f6f1b4

@tscrim
Copy link
Collaborator Author

tscrim commented Jan 10, 2014

comment:10

Because I think they are a very interesting class of groups (and GAP doesn't have them :p), I'd appreciate a review.

@tscrim
Copy link
Collaborator Author

tscrim commented Jan 10, 2014

Dependencies: #15603

@miguelmarco
Copy link
Contributor

comment:11

Would it make sense to inherit from FinitelyPresentedGroup? Things like the Alexander matrix could be interesting to have.

@fchapoton
Copy link
Contributor

comment:12
  1. the following does not work:

sage: G = RightAngledArtinGroup(graphs.EmptyGraph())

it should either fail more gracefully or succeed.

  1. there is a typo "creaing"

  2. maybe the string representation could use the string repr of the graph ? maybe instead of just the number of vertices ?

@tscrim
Copy link
Collaborator Author

tscrim commented Jan 10, 2014

comment:13

Replying to @miguelmarco:

Would it make sense to inherit from FinitelyPresentedGroup? Things like the Alexander matrix could be interesting to have.

I'm not sure. FinitelyPresentedGroup is a Gap group, this is implementation is pure python/Sage, and I don't know how to mix the two. There should be methods to construct the corresponding FP group, as well as the ability to pass this to Gap (as a FP group).

Replying to @fchapoton:

  1. the following does not work:

sage: G = RightAngledArtinGroup?(graphs.EmptyGraph?())

it should either fail more gracefully or succeed.

Grrr...boarder cases; I'll fix this after I see what would be the most consistent behavior.

  1. there is a typo "creaing"

Will fix.

  1. maybe the string representation could use the string repr of the graph ? maybe instead of just the number of vertices ?

That would be better; will change.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 13, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

7856bc4Made changes and expanded documentation.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 13, 2014

Changed commit from 0f6f1b4 to 7856bc4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 13, 2014

Changed commit from 7856bc4 to 457f00d

@tscrim
Copy link
Collaborator Author

tscrim commented Jan 16, 2014

Changed dependencies from #15603 to #15603 #15669

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

a784a50Merge branch 'develop' into public/groups/15137-raags
dae53afMerge branch 'develop' into ticket/15623
c5b6d59Re-insert a bit of code that had been erroneously deleted in the previous merge commit
81fc8a4Merge branch 'u/ncohen/15681' of trac.sagemath.org:sage into u/tscrim/15681
c393b58Merge branch 'public/graphs/complement-15699' of trac.sagemath.org:sage into public/graphs/complement-15669
744dd52Merge branch 'public/graphs/complement-15669' into public/groups/15137-raags

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2014

Changed commit from 2dff543 to 744dd52

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 16, 2014

Changed commit from 744dd52 to 0f5b6c8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 16, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

e1002a5Merge branch 'develop' into public/groups/15137-raags
0f5b6c8Merge branch 'develop' into public/groups/15137-raags

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 16, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

b30ad29Merge branch 'public/groups/15137-raags' of trac.sagemath.org:sage into public/groups/15137-raags
6e6d0efFixing bad merge and added RAAG's to the catalog.
86c8c87Rewrote RAAG as Gap group and did some logic/pickling cleanup of FP groups.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 16, 2014

Changed commit from 0f5b6c8 to 86c8c87

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 17, 2014

Changed commit from 86c8c87 to d78fc55

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 17, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

d78fc55Improving documentation from talking with Miguel.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 17, 2014

Changed commit from d78fc55 to ce328e8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 17, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

ce328e8Removed non-ascii character.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 17, 2014

Changed commit from ce328e8 to 473384d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 17, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

473384dFixed citation.

@miguelmarco
Copy link
Contributor

comment:27

Looks good.

@vbraun
Copy link
Member

vbraun commented Jun 18, 2014

comment:28

reviewer name

@tscrim
Copy link
Collaborator Author

tscrim commented Jun 18, 2014

Reviewer: Frédéric Chapoton, Miguel Marco

@tscrim
Copy link
Collaborator Author

tscrim commented Jun 19, 2014

Changed keywords from Artin group RAAG, days54 to Artin group RAAG, days54, sd58

@vbraun
Copy link
Member

vbraun commented Jun 19, 2014

Changed branch from public/groups/15137-raags to 473384d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants