a quick way to create trees

[fchapoton]

I propose a method to create (unlabelled) trees conveniently.

One enters a sequence of hexadecimal numbers, and this is converted into a rooted tree.

CC: @sagetrac-sage-combinat

Component: combinatorics

Keywords: trees

Author: Frédéric Chapoton

Reviewer: Travis Scrimshaw

Merged: sage-5.13.beta2

Issue created by migration from https://trac.sagemath.org/ticket/15121

[fchapoton]

Dependencies: #11529

[fchapoton]

Changed dependencies from #11529 to none

[fchapoton]

comment:2

now ready for review !

But where is the bot ? Still at the beach ?

[fchapoton]

Changed keywords from tree to trees

[tscrim]

comment:5

Hey Frederic,

Could you move from_hexcode to AbstractTree so the parent arg becomes self? IMO this way it is more discoverable and OOP.

Also (more of a pet-peeve of mine, so you can ignore this), I don't like else: statements following

if condition:
    ...
    return foo

(or an sequence of elif's) since it is unnecessary indentation.

Thanks,

Travis

[fchapoton]

Attachment: trac_15121_hexacode_for_trees-fc.patch.gz

[fchapoton]

comment:6

Humm, this does not seem possible, because there is no class AbstractTrees (with an s at the end)

Indeed, it does not seem reasonable to put that into the class AbstractTree, because it would mean one has to build a tree before one can build another one..

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:7

Ah, my bad. I thought there was a common parent class.

Looks good to me. Thanks.

[fchapoton]

comment:8

Thanks a lot Travis.

[jdemeyer]

Merged: sage-5.13.beta2