Skip to content

cleanup of doc in heegner.py #14595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fchapoton opened this issue May 15, 2013 · 13 comments
Closed

cleanup of doc in heegner.py #14595

fchapoton opened this issue May 15, 2013 · 13 comments
Assignees
@JohnCremona
Labels
c: documentation c: elliptic curves p: minor / 4 t: enhancement
Milestone
sage-5.11

Comments

@fchapoton
Copy link
Contributor

this patch proposes to clean the heegner.py file :

Some things found using pyflakes:

  • removing one duplicate import
  • removing unused variables assignements
    plus
  • removing trailing whitespaces
  • minor doc formatting
  • convert raise statements to python3 syntax

Apply attachment: trac_14595_clean_heegner-fc.patch

Depends on #13213

Component: elliptic curves

Keywords: heegner

Author: Frédéric Chapoton

Reviewer: Volker Braun

Merged: sage-5.11.beta0

Issue created by migration from https://trac.sagemath.org/ticket/14595
@fchapoton fchapoton added this to the sage-5.10 milestone May 15, 2013
@vbraun
Copy link
Member

vbraun commented May 16, 2013

comment:1

Needs review?

@fchapoton
Copy link
Contributor Author

Author: Frédéric Chapoton

@fchapoton
Copy link
Contributor Author

comment:2

oh, yes, indeed. I forgot to click on needs review.

@vbraun
Copy link
Member

vbraun commented May 17, 2013

comment:3

Looks good but needs to be rebased on top of #13213

@vbraun
Copy link
Member

vbraun commented May 17, 2013

Dependencies: 13213

@fchapoton
Copy link
Contributor Author

Attachment: trac_14595_clean_heegner-fc.patch.gz

@fchapoton
Copy link
Contributor Author

comment:4

here is a rebased patch

@fchapoton
Copy link
Contributor Author

Changed dependencies from 13213 to #13213

@fchapoton
Copy link
Contributor Author

comment:5

bot has given a green light, is there anybody here for a review ?

@vbraun
Copy link
Member

vbraun commented May 29, 2013

comment:6

lgtm

@vbraun

This comment has been minimized.

Sign in to view
@vbraun
Copy link
Member

vbraun commented May 29, 2013

Reviewer: Volker Braun

@jdemeyer jdemeyer modified the milestones: sage-5.10, sage-5.11 May 29, 2013
@jdemeyer
Copy link
Contributor

jdemeyer commented Jun 6, 2013

Merged: sage-5.11.beta0

@jdemeyer jdemeyer closed this as completed Jun 6, 2013
@cnassau cnassau mentioned this issue Jul 31, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnCremona JohnCremona

Labels
c: documentation c: elliptic curves p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-5.11
Development

No branches or pull requests
4 participants
@vbraun @JohnCremona @jdemeyer @fchapoton