-
-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A first step towards linear systems of hypersurfaces in Sage #12995
Comments
Author: Moritz Minzlaff |
Reviewer: David Eklund |
comment:3
All tests pass on Sage 5.2 and Mac OS X lion (except two tests that fail on an unpatched Sage 5.2). Let me look through the details and test the functionality and get back here. |
comment:4
In the documentation part of the patch it says that the output is a matrix of size
but is the number of columns really |
comment:5
The syntax
has been deprecated in Python. http://docs.python.org/release/2.6.8/tutorial/errors.html#raising-exceptions We should use
instead. |
comment:6
Tests pass on Sage 5.3 (Mac OS X lion) also. |
comment:7
Dear David, thanks for your remarks and your time to review this patch! I have uploaded a new version of the patch moments ago. You are quite right about the d+1 vs. d+n thing. I have also changed the syntax for raising Errors as you suggested. |
comment:8
Ok, looks good! I will put this to positive review soon. |
Attachment: trac_12995_review.patch.gz Fixed typos and line continuation of strings. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:11
Hi! I have a question: It says in the documentation part that the output is with respect to reverse lexicographic ordering of monomials. But it seems to me that, for example in the case of degree 2 in projective 2-space the monomials are ordered as:
which seems to be just the lexicographic ordering rather than reverse lexicographic ordering. If you agree I can incorporate this change into the review patch. |
comment:12
I don't have time tonight to answer your question, but I'll try to look at it tomorrow! |
comment:13
Ok, this looks good! If you agree with the changes in the review patch and we resolve the issue about the monomial ordering, then we are good to go. |
Attachment: trac_12995_review2.patch.gz fixes two more things in documentation/comments |
This comment has been minimized.
This comment has been minimized.
comment:15
Hi David, please excuse my slow response. I've recently left academia and can only find time to look at Sage in the evenings (but I am happy to do so!). Thanks again for your comments. You are quite right, I've changed the documentation accordingly. I also saw where I got confused and changed one line of comment, too. :) |
comment:16
Thanks! Actually, I think you are responding very quickly. I will try to get the patch bot to apply the right patches so that we can get rid of the ugly red blob at the top. |
comment:17
For the patchbot: Apply trac_12995_initial.patch, trac_12995_review2.patch |
Merged: sage-5.5.beta0 |
comment:22
Could you please make the commit message more descriptive than "incorporates David's remarks". |
comment:23
Yes, a more descriptive message would be better. Moritz, do you think you can take care of this? Thanks! |
comment:24
Hi, I will get to it later tonight/tomorrow. |
Attachment: trac_12995_initial.patch.gz |
comment:25
Ok, done. :) |
comment:26
Thanks! |
In Magma, one can do the following:
Sage does not have this functionality. This patch will be a first step towards adding a class LinearSystem to Sage.
The goal is to add a method _linear_system_as_kernel to projective spaces that returns a matrix whose kernel can be identified with the degree d hypersurfaces with multiplicity at least m at pt.
(I actually need this method in the context of equimultiple liftings of plane curves over finite fields for which I will open a separate ticket.)
Apply:
Component: algebraic geometry
Author: Moritz Minzlaff
Reviewer: David Eklund
Merged: sage-5.5.beta0
Issue created by migration from https://trac.sagemath.org/ticket/12995
The text was updated successfully, but these errors were encountered: