Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve doctest coverage of matrix/benchmark.py from 0% to 100% #12034

Closed
williamstein opened this issue Nov 15, 2011 · 10 comments
Closed

improve doctest coverage of matrix/benchmark.py from 0% to 100% #12034

williamstein opened this issue Nov 15, 2011 · 10 comments

Comments

@williamstein
Copy link
Contributor

Part of metaticket #12024

Apply:

CC: @malb

Component: linear algebra

Author: William Stein

Reviewer: Martin Albrecht, Karl-Dieter Crisman

Merged: sage-5.0.beta4

Issue created by migration from https://trac.sagemath.org/ticket/12034

@williamstein
Copy link
Contributor Author

Attachment: trac_12034.patch.gz

@williamstein
Copy link
Contributor Author

Author: wstein

@malb
Copy link
Member

malb commented Nov 15, 2011

comment:3

Attachment: trac_12034_reviewer.patch.gz

I've added a reviewer patch which adds INPUT: blocks and fixes some wrongly stated default parameters.

@kcrisman
Copy link
Member

comment:4

Martin, does that mean you give positive review to William's patch? It looks fine at a glance... Anyway, putting "needs info" for this.

Other than not obeying the recommendation from the developer guide about .. note

However, you are encouraged to use the upper-case version

which is not a problem at all, the reviewer patch looks fine, including the very minor code changes. Just one or two very minor formatting things.

I've attached a reviewer-reviewer patch which fixes these and adds this to the reference manual.

@kcrisman
Copy link
Member

Reviewer: Martin Albrecht, Karl-Dieter Crisman

@kcrisman
Copy link
Member

Changed author from wstein to William Stein

@kcrisman

This comment has been minimized.

@kcrisman
Copy link
Member

comment:5

Attachment: trac_12034-reviewer-reviewer.patch.gz

@malb
Copy link
Member

malb commented Feb 10, 2012

comment:6

I'm fine with William's and your patches.

@jdemeyer
Copy link
Contributor

Merged: sage-5.0.beta4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants