-
-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve doctest coverage of matrix/benchmark.py from 0% to 100% #12034
Comments
Attachment: trac_12034.patch.gz |
Author: wstein |
comment:3
Attachment: trac_12034_reviewer.patch.gz I've added a reviewer patch which adds |
comment:4
Martin, does that mean you give positive review to William's patch? It looks fine at a glance... Anyway, putting "needs info" for this. Other than not obeying the recommendation from the developer guide about
which is not a problem at all, the reviewer patch looks fine, including the very minor code changes. Just one or two very minor formatting things. I've attached a reviewer-reviewer patch which fixes these and adds this to the reference manual. |
Reviewer: Martin Albrecht, Karl-Dieter Crisman |
Changed author from wstein to William Stein |
This comment has been minimized.
This comment has been minimized.
comment:5
Attachment: trac_12034-reviewer-reviewer.patch.gz |
comment:6
I'm fine with William's and your patches. |
Merged: sage-5.0.beta4 |
Part of metaticket #12024
Apply:
CC: @malb
Component: linear algebra
Author: William Stein
Reviewer: Martin Albrecht, Karl-Dieter Crisman
Merged: sage-5.0.beta4
Issue created by migration from https://trac.sagemath.org/ticket/12034
The text was updated successfully, but these errors were encountered: