-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix more noise on MacOS X 10.4 PPC #11901
Comments
Sage library patch. Based on Sage 4.7.2.alpha3 / #7852. |
comment:1
Attachment: trac_11901-adjust_threshold_for_noisy_zero_terms_in_polynomial_element.patch.gz A single-character patch to be tested (by "student") and reviewed... |
Author: Leif Leonhardy |
This comment has been minimized.
This comment has been minimized.
comment:2
This looks good to me, but I think we need to see if it does the job on Mac PowerPC? |
comment:3
I know this is sort of silly, but it is nice to have all tests pass :) Works fine.
|
Reviewer: Karl-Dieter Crisman, Rob Beezer |
Merged: sage-4.7.2.alpha4 |
comment:4
Thanks! |
comment:5
Replying to @jdemeyer:
So Moufang is still alive? |
comment:6
Replying to @nexttime:
Of course. Did I ever say it wasn't? I don't actually use this machine, only to test Sage. |
This is a follow-up to #7852 (and #11897).
As reported on sage-release, some doctests in Sage 4.7.2.alpha3 still failed on a PowerPC running MacOS X 10.4 due to numerical noise (or slightly different behaviour, giving correct but varying results).
The patch here further increases the threshold for noisy zero terms of polynomials slightly.
Apply
to the Sage library.
CC: @kcrisman @rbeezer
Component: linear algebra
Keywords: noisy zero epsilon threshold polynomial term
Author: Leif Leonhardy
Reviewer: Karl-Dieter Crisman, Rob Beezer
Merged: sage-4.7.2.alpha4
Issue created by migration from https://trac.sagemath.org/ticket/11901
The text was updated successfully, but these errors were encountered: