Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more noise on MacOS X 10.4 PPC #11901

Closed
nexttime mannequin opened this issue Oct 6, 2011 · 11 comments
Closed

Fix more noise on MacOS X 10.4 PPC #11901

nexttime mannequin opened this issue Oct 6, 2011 · 11 comments

Comments

@nexttime
Copy link
Mannequin

nexttime mannequin commented Oct 6, 2011

This is a follow-up to #7852 (and #11897).

As reported on sage-release, some doctests in Sage 4.7.2.alpha3 still failed on a PowerPC running MacOS X 10.4 due to numerical noise (or slightly different behaviour, giving correct but varying results).

The patch here further increases the threshold for noisy zero terms of polynomials slightly.


Apply

  1. attachment: trac_11901-adjust_threshold_for_noisy_zero_terms_in_polynomial_element.patch
    to the Sage library.

CC: @kcrisman @rbeezer

Component: linear algebra

Keywords: noisy zero epsilon threshold polynomial term

Author: Leif Leonhardy

Reviewer: Karl-Dieter Crisman, Rob Beezer

Merged: sage-4.7.2.alpha4

Issue created by migration from https://trac.sagemath.org/ticket/11901

@nexttime nexttime mannequin added this to the sage-4.7.2 milestone Oct 6, 2011
@nexttime nexttime mannequin assigned jasongrout and williamstein Oct 6, 2011
@nexttime
Copy link
Mannequin Author

nexttime mannequin commented Oct 6, 2011

Sage library patch. Based on Sage 4.7.2.alpha3 / #7852.

@nexttime
Copy link
Mannequin Author

nexttime mannequin commented Oct 6, 2011

comment:1

Attachment: trac_11901-adjust_threshold_for_noisy_zero_terms_in_polynomial_element.patch.gz

A single-character patch to be tested (by "student") and reviewed...

@nexttime
Copy link
Mannequin Author

nexttime mannequin commented Oct 6, 2011

Author: Leif Leonhardy

@nexttime

This comment has been minimized.

@nexttime nexttime mannequin added the s: needs review label Oct 6, 2011
@rbeezer
Copy link
Mannequin

rbeezer mannequin commented Oct 7, 2011

comment:2

This looks good to me, but I think we need to see if it does the job on Mac PowerPC?

@kcrisman
Copy link
Member

kcrisman commented Oct 7, 2011

comment:3

I know this is sort of silly, but it is nice to have all tests pass :)

Works fine.

sage -t -long "devel/sage/sage/rings/polynomial/polynomial_element.pyx"
         [156.8 s]
 
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 157.4 seconds

@kcrisman
Copy link
Member

kcrisman commented Oct 7, 2011

Reviewer: Karl-Dieter Crisman, Rob Beezer

@jdemeyer
Copy link
Contributor

jdemeyer commented Oct 8, 2011

Merged: sage-4.7.2.alpha4

@jdemeyer
Copy link
Contributor

jdemeyer commented Oct 8, 2011

comment:4

Thanks!

@nexttime
Copy link
Mannequin Author

nexttime mannequin commented Oct 8, 2011

comment:5

Replying to @jdemeyer:

Thanks!

So Moufang is still alive?

@jdemeyer
Copy link
Contributor

jdemeyer commented Oct 8, 2011

comment:6

Replying to @nexttime:

So Moufang is still alive?

Of course. Did I ever say it wasn't? I don't actually use this machine, only to test Sage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants