-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use new app deployment url #1472
Conversation
Branch preview⏳ Deploying a preview site... |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch!
docs/environments.md
Outdated
@@ -1,18 +1,17 @@ | |||
# Environments | |||
|
|||
⚠️ URLs to be updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove this warning?
docs/environments.md
Outdated
|staging|https://safe-team.staging.gnosisdev.com/app/|preview of features before a release|on push to `main`|staging| | ||
|production|https://gnosis-safe.io/app/|live app|deployed by DevOps (see the [Release Procedure](https://github.com/safe-global/safe-react/blob/ee39ef932d58e67db96756577814c1bfaf396d75/docs/release-procedure.md))|**production**| | ||
|PRs |`https://<PR_NAME>--webcore.review-web-core.5afe.dev/`|peer review & feature QA|for all PRs on push|staging| | ||
|release PRs|`https://<PR_NAME>--webcore.review-web-core.5afe.dev/`|pre-release regression testing|in PRs to `main`|**production** (sic!)| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not accurate anymore, btw. Can be deleted. RCs are just like regular branches.
What it solves
Resolves #1231
How this PR fixes it
Rewrites the remaining links to
safe.global
How to test it