Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new app deployment url #1472

Merged
merged 2 commits into from
Jan 2, 2023
Merged

fix: use new app deployment url #1472

merged 2 commits into from
Jan 2, 2023

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Jan 2, 2023

What it solves

Resolves #1231

How this PR fixes it

Rewrites the remaining links to safe.global

  • One link during SafeCreation (What Safe Setup should I use?)
  • links in the developer markdown docs

How to test it

  • Check the links in the developer docs
  • Check the link in SafeCreation

@schmanu schmanu requested a review from DiogoSoaress January 2, 2023 11:54
@github-actions
Copy link

github-actions bot commented Jan 2, 2023

Branch preview

⏳ Deploying a preview site...

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@@ -1,18 +1,17 @@
# Environments

⚠️ URLs to be updated!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this warning?

|staging|https://safe-team.staging.gnosisdev.com/app/|preview of features before a release|on push to `main`|staging|
|production|https://gnosis-safe.io/app/|live app|deployed by DevOps (see the [Release Procedure](https://github.com/safe-global/safe-react/blob/ee39ef932d58e67db96756577814c1bfaf396d75/docs/release-procedure.md))|**production**|
|PRs |`https://<PR_NAME>--webcore.review-web-core.5afe.dev/`|peer review & feature QA|for all PRs on push|staging|
|release PRs|`https://<PR_NAME>--webcore.review-web-core.5afe.dev/`|pre-release regression testing|in PRs to `main`|**production** (sic!)|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not accurate anymore, btw. Can be deleted. RCs are just like regular branches.

@katspaugh katspaugh merged commit b700e68 into dev Jan 2, 2023
@katspaugh katspaugh deleted the fix-use-new-url branch January 2, 2023 13:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update links to new domain (safe.global)
2 participants