Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce that dataHash is the hash of data #497

Closed
rmeissner opened this issue Jan 20, 2023 · 1 comment
Closed

Enforce that dataHash is the hash of data #497

rmeissner opened this issue Jan 20, 2023 · 1 comment
Assignees
@mmv08
Milestone
Version 1.4.0

Comments

@rmeissner
Copy link
Member

rmeissner commented Jan 20, 2023 •
edited by mmv08
Loading

It is not enforced that dataHash is the hash of data. It would make sense to add a require for this to avoid unexpected behaviour.

Reference: https://github.com/safe-global/safe-contracts/blob/3c3fc80f7f9aef1d39aaae2b53db5f4490051b0d/contracts/Safe.sol#L286-L316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmv08 mmv08

Labels
None yet
Projects
None yet
Milestone
Version 1.4.0
Development

No branches or pull requests
3 participants
@rmeissner @mmv08 and others