From 07514e54398f7deacc2790cf55a4f293ad176684 Mon Sep 17 00:00:00 2001 From: Daniel <25051234+dasanra@users.noreply.github.com> Date: Thu, 23 Nov 2023 16:32:02 +0100 Subject: [PATCH] fix wording recommendations --- safe-core-sdk/onramp-kit/reference/MoneriumPack.md | 2 +- safe-core-sdk/onramp-kit/reference/README.md | 8 ++++---- safe-core-sdk/protocol-kit/README.md | 8 ++++---- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/safe-core-sdk/onramp-kit/reference/MoneriumPack.md b/safe-core-sdk/onramp-kit/reference/MoneriumPack.md index bd01aa58..7c5e1943 100644 --- a/safe-core-sdk/onramp-kit/reference/MoneriumPack.md +++ b/safe-core-sdk/onramp-kit/reference/MoneriumPack.md @@ -4,7 +4,7 @@ Monerium Pack enables using Safe with [Monerium](https://monerium.com), a regula ## Install dependencies -To use the `MoneriumPack`, you need to install the monerium SDK in addition to the `@safe-global/onramp-kit` package. +To use the `MoneriumPack`, you need to install the Monerium SDK in addition to the `@safe-global/onramp-kit` package. ```bash yarn add @safe-global/onramp-kit @monerium/sdk diff --git a/safe-core-sdk/onramp-kit/reference/README.md b/safe-core-sdk/onramp-kit/reference/README.md index acf05bd1..fb4a81ff 100644 --- a/safe-core-sdk/onramp-kit/reference/README.md +++ b/safe-core-sdk/onramp-kit/reference/README.md @@ -1,17 +1,17 @@ -# OnRamp Kit +# Onramp Kit -The [OnRamp Kit](https://github.com/safe-global/safe-core-sdk/tree/main/packages/onramp-kit) allow users to access on-ramp services and use them with their Safes. +The [Onramp Kit](https://github.com/safe-global/safe-core-sdk/tree/main/packages/onramp-kit) allow users to access on-ramp services and use them with their Safes. These services can be used to buy crypto assets with credit cards or make SEPA transfers between their Safe and bank accounts (Monerium). ## Install dependencies -To add the OnRamp Kit to your project, run: +To add the Onramp Kit to your project, run: ```bash yarn add @safe-global/onramp-kit ``` -The OnRamp Kit can integrate several providers in the form of "packs". A pack is a piece of code that works with the chosen provider to give Safe users access to new services. +The Onramp Kit can integrate several providers in the form of "packs". A pack is a piece of code that works with the chosen provider to give Safe users access to new services. To use each pack, the right package needs to be installed: diff --git a/safe-core-sdk/protocol-kit/README.md b/safe-core-sdk/protocol-kit/README.md index b0e88619..596bd20a 100644 --- a/safe-core-sdk/protocol-kit/README.md +++ b/safe-core-sdk/protocol-kit/README.md @@ -11,11 +11,11 @@ For a more detailed guide, including how to integrate with `web3.js`` and more S ### Prerequisites 1. [Node.js and npm](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm) -2. 3 externally-owned accounts with testnet ETH in at least one account +2. 3 externally-owned accounts with Testnet ETH in at least one account ### Install dependencies -First, we'll need to install some dependences from `safe-core-sdk` and the `ethers` library. +First, we'll need to install some dependencies from `safe-core-sdk` and the `ethers` library. To interact with Ethereum and other EVM blockchains in Node, we can either use: web3.js or ethers.js. In this tutorial, we'll use the ethers.js library. To use `web3js`, see [Instantiate an EthAdapter section in Guide: Integrating the Safe Core SDK](https://github.com/safe-global/safe-core-sdk/blob/main/guides/integrating-the-safe-core-sdk.md#instantiate-an-ethadapter). @@ -62,7 +62,7 @@ The signers trigger transactions to the Ethereum blockchain or off-chain transac You can get a public RPC URL from [Chainlist](https://chainlist.org), however, public RPC URLs can be unreliable so you can also try a dedicated provider like Infura or Alchemy. -For this tutorial, we will be creating a Safe on the Goerli testnet. +For this tutorial, we will be creating a Safe on the Goerli Testnet. ```tsx import { ethers } from 'ethers' @@ -240,7 +240,7 @@ Recall that you created the `safeService` in [Initialize the API Kit](./#initial const pendingTransactions = await safeService.getPendingTransactions(safeAddress).results ``` -### Confirm the transaction: second confirmation +### Confirm the transaction: Second confirmation When owner 2 is connected to the application, the Protocol Kit should be initialized again with the existing Safe address the address of the owner 2 instead of the owner 1.