Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SafeSingeltonFactory by default for new deployments #460

Closed
rmeissner opened this issue Dec 16, 2022 · 1 comment
Closed

Use SafeSingeltonFactory by default for new deployments #460

rmeissner opened this issue Dec 16, 2022 · 1 comment
Assignees
@mmv08
Milestone
Version 1.4.0

Comments

@rmeissner
Copy link
Member

Currently the contract use the https://github.com/Arachnid/deterministic-deployment-proxy by default. This contract is not available on all networks (considering only fully evm compatible networks). Therefore the default should be https://github.com/gnosis/safe-singleton-factory. Also deployment should throw an error if the factory is not available for a specific network (currently it falls back to the default).
@rmeissner rmeissner added this to the Version 1.4.0 milestone Dec 16, 2022
@mmv08 mmv08 mentioned this issue Dec 24, 2022
Merged
@mmv08 mmv08 self-assigned this Dec 24, 2022
@mmv08
Copy link
Member

mmv08 commented Dec 25, 2022

Implemented in #469

@mmv08 mmv08 closed this as completed Dec 25, 2022
@moisses89 moisses89 mentioned this issue Jan 5, 2023
Closed
@moisses89 moisses89 mentioned this issue Apr 25, 2023
Closed
fdarian pushed a commit to fdarian/safe-contracts that referenced this issue Jan 14, 2024
@germartinez
Replace Safe{Core} SDK logo (safe-global#460)
46e4d80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmv08 mmv08

Labels
None yet
Projects
None yet
Milestone
Version 1.4.0
Development

No branches or pull requests
2 participants
@rmeissner @mmv08