refac(js): Do not use number type for object key

ryym · ryym · commit 58f90f7bc54e · 2018-04-20T13:35:11.000+09:00
Keys are converted as string internally. microsoft/TypeScript#13715
diff --git a/frontend/lib/models.ts b/frontend/lib/models.ts
@@ -13,7 +13,7 @@ export interface Bookmark {
 }
 
 export interface BookmarkById {
-  readonly [id: number]: Bookmark;
+  readonly [id: string]: Bookmark;
 }
 
 export interface SearchCondition {
diff --git a/frontend/state.ts b/frontend/state.ts
@@ -8,7 +8,7 @@ export interface State {
 export interface BookmarkState {
   readonly nowLoading: boolean;
   readonly byId: {
-    readonly [id: number]: Bookmark;
+    readonly [id: string]: Bookmark;
   };
 }
 

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ export interface Bookmark {`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`export interface BookmarkById {`
`16`		`- readonly [id: number]: Bookmark;`
	`16`	`+ readonly [id: string]: Bookmark;`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`export interface SearchCondition {`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ export interface State {`
`8`	`8`	`export interface BookmarkState {`
`9`	`9`	`readonly nowLoading: boolean;`
`10`	`10`	`readonly byId: {`
`11`		`- readonly [id: number]: Bookmark;`
	`11`	`+ readonly [id: string]: Bookmark;`
`12`	`12`	`};`
`13`	`13`	`}`
`14`	`14`