Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agile Screen and Usage Screen: Move partitioned cell calculation to ViewModel #251

Open
ryanw-mobile opened this issue Jul 3, 2024 · 0 comments
Assignees
Labels
refactor Refactoring production code, eg. renaming a variable.

Comments

@ryanw-mobile
Copy link
Owner

Right now we split the data set according to the requested number of columns at composables and use remember to cache that.
Obviously we use the UI thread for doing that, which can be avoided.

Moving the calculation back to ViewModel allows us to pick whichever dispatcher to do that, and we can include the results as a part of unit test (which in case we finally cover view model tests).

This is a low-priority work. Generally, it won't be done before we conclude this project in July 2024.

@ryanw-mobile ryanw-mobile added the refactor Refactoring production code, eg. renaming a variable. label Jul 3, 2024
@ryanw-mobile ryanw-mobile self-assigned this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring production code, eg. renaming a variable.
Projects
None yet
Development

No branches or pull requests

1 participant