Show lerna-changelog output _before_ version prompt. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a significant refactor (of both implementation, and tests). The main goal is to ensure that the changelog that is displayed before selecting what the next version will be is from lerna-changelog (not whatever is configured as `git.changelog` script). This makes it much much easier to see that lerna-changelog labels have been applied, and (assuming they have) what the right version to select is. This also significantly refactors the testing harness to much closer simulate actually executing `lerna-changelog` and the various `git` commands (`plugin.responses` is a simple matcher for the command and returns the value).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a significant refactor (of both implementation, and tests). The main goal is to ensure that the changelog that is displayed before selecting what the next version will be is from lerna-changelog (not whatever is configured as
git.changelogscript). This makes it much much easier to see that lerna-changelog labels have been applied, and (assuming they have) what the right version to select is.This also significantly refactors the testing harness to much closer simulate actually executing
lerna-changelogand the variousgitcommands (plugin.responsesis a simple matcher for the command and returns the value).