Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminate on unknown wasm-bindgen target #483

Closed
pickfire opened this issue Jan 8, 2019 · 1 comment
Closed

Terminate on unknown wasm-bindgen target #483

pickfire opened this issue Jan 8, 2019 · 1 comment
Labels
bug Something isn't working changelog - fix PR attached there's a PR open for this issue user report
Milestone
0.6.0

Comments

@pickfire
Copy link

pickfire commented Jan 8, 2019

🐛 Bug description

$ wasm-pack build --target=node

build works but then I found out that it is still a browser target.

To my surprise, the following works and defaults to browser target.

$ wasm-pack build --target=random

🤔 Expected Behavior

wasm-pack fail right away showing the available targets and display unknown target supplied.

👟 Steps to reproduce

Just wasm-pack build --target=insert_here.

🌍 Your environment

Include the relevant details of your environment.
wasm-pack version: wasm-pack 0.5.1
rustc version: rustc 1.31.1 (b6c32da9b 2018-12-18)
@pickfire pickfire changed the title terminate on unknown wasm-bindgen target Terminate on unknown wasm-bindgen target Jan 8, 2019
@csmoe
Copy link
Member

csmoe commented Jan 10, 2019

due to possible_values not supported in strcutopt yet.

@csmoe csmoe mentioned this issue Jan 10, 2019
Merged
@ashleygwilliams ashleygwilliams added the PR attached there's a PR open for this issue label Jan 10, 2019
@ashleygwilliams ashleygwilliams added this to the 0.6.0 milestone Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working changelog - fix PR attached there's a PR open for this issue user report
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
3 participants
@ashleygwilliams @pickfire @csmoe