-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify intent of wasm-pack and commands #466
Comments
The commands section in the book describes the commands pretty well and does clarify that publishing is optional. So I guess there could be some improvements here:
Let me know if there are established best practices already, I'd be happy to send a PR to try to clarify. |
hi @grovesNL ! you are absolutely correct- wasm-pack certainly doesn't require that you publish to the registry. originally, when we came up with wasm-pack it was indeed just a publishing tool- however it's since grown into an integrated build tool that does quite a bit more than was the original plan, and certainly doesn't require that folks publish. i would welcome a PR to update the messaging if you're interested. i intend to get a release out today/tomorrow, and can also do some wordsmithing (and website improvement) :) thanks for filing! |
this is going to be handled partially by a PR in this repo and partially in a set of others! i'm closing because we'll file more granular issues for the to do items, thank you so much for this thoughtful issue! it was very helpful :) |
Sounds great, thank you! |
The description of wasm-pack in this repository:
This seems to indicate wasm-pack is only used when publishing the output to a registry, but wasm-pack appears to be usable for other use cases. The front page at https://rustwasm.github.io/wasm-pack/ also doesn't contain many details which makes it difficult to understand the intended use cases. This is a bit confusing for users that don't want to publish to npm (for example, running
wasm-pack build
for internal use in their project).I wanted to raise this here because rustwasm/wasm-bindgen#1120 mentioned that wasm-pack is an appropriate replacement for the example build scripts there. It seems to be working great and gives me the expected output, but I'm unsure if I'm misusing the CLI (
Your wasm pkg is ready to publish at "/Users/josh/Projects/js-hello-world/pkg".
even though I don't want to publish anything).The text was updated successfully, but these errors were encountered: