-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug build windows appveyor releases #147
Comments
I have the experience of setting up AppVeyor for libui-rs and I'm glad to do the job at this weekend, if you're ok. |
That would be super super helpful! :D If you want to take a crack at that please do :) |
thanks so much for volunteering @huangjj27 ! |
Before I start the job, I want to make it clear which channel and target should I test, Could you give me some advice? I think I should make an exmaple for |
@huangjj27 at the very least, i would like to have parity with wasm-bindgen, which does this https://github.com/rustwasm/wasm-bindgen/blob/master/.appveyor.yml#L7, targeting that being said- if there are other targets you think we should use appveyor for as well, we're very open to hearing more! feel free to broaden the horizon if you wish to, just be sure to explain your rationale here at some point :) thanks again for taking this on! |
I found that you already have a |
hi @huangjj27 i'm not sure we need to rename it in order for it to build releases for us... it works fine in |
Hi, @ashleygwilliams, I'm sorry I'm confused. It seems that the original yml works fine for wasm-pack, and I don't think we need change the config, unless we want to test it on more target or toolchain. Besides, according to AppVeyor's doc, renaming the config file make no difference, which I thought it have to be without prefix-dot. |
@ashleygwilliams Don't we already have the windows build? Do you mean something else here. |
@huangjj27 @sendilkumarn the purpose of this issue is to instruct our current appveyor CI to publish the builds it makes as releases to our releases page here on github (https://github.com/ashleygwilliams/wasm-pack/releases). you can see on this page that we are building OSX and linux. i'd like to get the windows one going as well, as we also support windows. this is a help document on how to do it! https://www.appveyor.com/docs/deployment/github/ - i'll need to get it set up with a key but i thought someone might be interested in making the PR that adds everything but the key! here is an example on the let me know if there are any other questions :) |
ugh wait. i'm the worst.. it is building releases... or it is supposed to be building releases. seems like this is not a feature request but a bugfix! sorry ya'll. |
we currently make release binaries for linux and mac using travis. we should also do this for windows with appveyor!
The text was updated successfully, but these errors were encountered: