Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug build windows appveyor releases #147

Closed
ashleygwilliams opened this issue Jun 5, 2018 · 11 comments · Fixed by #301
Closed

debug build windows appveyor releases #147

ashleygwilliams opened this issue Jun 5, 2018 · 11 comments · Fixed by #301
Labels
bug Something isn't working help wanted Extra attention is needed to-do stuff that needs to happen, so plz do it k thx
Milestone

Comments

@ashleygwilliams
Copy link
Member

we currently make release binaries for linux and mac using travis. we should also do this for windows with appveyor!

@ashleygwilliams ashleygwilliams added help wanted Extra attention is needed to-do stuff that needs to happen, so plz do it k thx labels Jun 5, 2018
@ashleygwilliams ashleygwilliams added this to the 0.4.0 milestone Jun 5, 2018
@huangjj27
Copy link
Member

I have the experience of setting up AppVeyor for libui-rs and I'm glad to do the job at this weekend, if you're ok.

@mgattozzi
Copy link
Contributor

That would be super super helpful! :D If you want to take a crack at that please do :)

@ashleygwilliams
Copy link
Member Author

thanks so much for volunteering @huangjj27 !

@huangjj27
Copy link
Member

huangjj27 commented Jun 7, 2018

Before I start the job, I want to make it clear which channel and target should I test, Could you give me some advice? I think I should make an exmaple for nightly-x86_64-pc-windows-msvc, for wasm32-unknown-unknown is not stable.

@ashleygwilliams
Copy link
Member Author

@huangjj27 at the very least, i would like to have parity with wasm-bindgen, which does this https://github.com/rustwasm/wasm-bindgen/blob/master/.appveyor.yml#L7, targeting x86_64-pc-windows-msvc on nightly. (your intuitions were totally correct!)

that being said- if there are other targets you think we should use appveyor for as well, we're very open to hearing more! feel free to broaden the horizon if you wish to, just be sure to explain your rationale here at some point :)

thanks again for taking this on!

@huangjj27
Copy link
Member

huangjj27 commented Jun 7, 2018

I found that you already have a .appveyor.yml file, Can't that be used for build? If it can, what we need to do is just to rename it to appveyor.yml

@huangjj27 huangjj27 mentioned this issue Jun 7, 2018
3 tasks
@ashleygwilliams
Copy link
Member Author

hi @huangjj27 i'm not sure we need to rename it in order for it to build releases for us... it works fine in wasm-bindgen as .appveyor.yml. is there a reason you think it needs to be renamed?

@huangjj27
Copy link
Member

huangjj27 commented Jun 7, 2018

Hi, @ashleygwilliams, I'm sorry I'm confused.

It seems that the original yml works fine for wasm-pack, and I don't think we need change the config, unless we want to test it on more target or toolchain.

Besides, according to AppVeyor's doc, renaming the config file make no difference, which I thought it have to be without prefix-dot.

@sendilkumarn
Copy link
Member

@ashleygwilliams Don't we already have the windows build? Do you mean something else here.

@ashleygwilliams
Copy link
Member Author

@huangjj27 @sendilkumarn the purpose of this issue is to instruct our current appveyor CI to publish the builds it makes as releases to our releases page here on github (https://github.com/ashleygwilliams/wasm-pack/releases). you can see on this page that we are building OSX and linux. i'd like to get the windows one going as well, as we also support windows.

this is a help document on how to do it! https://www.appveyor.com/docs/deployment/github/ - i'll need to get it set up with a key but i thought someone might be interested in making the PR that adds everything but the key! here is an example on the wasm-bindgen repo: https://github.com/rustwasm/wasm-bindgen/blob/master/.appveyor.yml#L39

let me know if there are any other questions :)

@ashleygwilliams
Copy link
Member Author

ugh wait. i'm the worst.. it is building releases... or it is supposed to be building releases. seems like this is not a feature request but a bugfix! sorry ya'll.

@ashleygwilliams ashleygwilliams added the bug Something isn't working label Jun 12, 2018
@ashleygwilliams ashleygwilliams changed the title build windows releases using appveyor debug build windows appveyor releases Jun 12, 2018
@ashleygwilliams ashleygwilliams modified the milestones: 0.4.0, 0.5.0 Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed to-do stuff that needs to happen, so plz do it k thx
Projects
None yet
4 participants