Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unmaintained wee_alloc #70

Closed
tgross35 opened this issue Mar 22, 2023 · 1 comment · Fixed by #71
Closed

Remove unmaintained wee_alloc #70

tgross35 opened this issue Mar 22, 2023 · 1 comment · Fixed by #71
Labels
bug Something isn't working

Comments

@tgross35
Copy link
Contributor

tgross35 commented Mar 22, 2023

Github throws a dependabot alert for any projects that use wee_alloc:

Two of the maintainers have indicated that the crate may not be maintained.

The crate has open issues including memory leaks and may not be suitable for production use.

It may be best to switch to the default Rust standard allocator on wasm32 targets.

Last release seems to have been three years ago.

This means that somebody who follows the quickstart and does wasm-pack new hello-wasm then pushes to GH immediately gets a security alert - not great for user experience.

The repo is in a pretty unfortunate state anyway https://github.com/rustwasm/wee_alloc

See also: discussion about the RUSTSEC advisory rustsec/advisory-db#1394

@tgross35 tgross35 added the bug Something isn't working label Mar 22, 2023
@jack-mil
Copy link

I am in support of this. Packages being out of date in this template caused me some issues when running through the wasm game of life tutorial book. The documentation in the book should also have references to wee_alloc removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants