rename Node::new_node to something more specific "from_type_and_metadata"

Signed-off-by: simonsan <[email protected]>

Author: simonsan

crates/core/src/archiver/tree.rs

@@ -99,7 +99,8 @@ where
                                     mode: Some(0o755),
                                     ..Default::default()
                                 };
-                                let node = Node::new_node(&p, NodeType::Dir, meta).ok()?;
+                                let node =
+                                    Node::from_type_and_metadata(&p, NodeType::Dir, meta).ok()?;
                                 return Some(TreeType::NewTree((self.path.clone(), node, p)));
                             }
                         }

crates/core/src/backend/ignore.rs

@@ -392,13 +392,13 @@ fn map_entry(
     };
 
     let node = if m.is_dir() {
-        Node::new_node(name, NodeType::Dir, meta)
+        Node::from_type_and_metadata(name, NodeType::Dir, meta)
     } else if m.is_symlink() {
         let target = read_link(entry.path()).map_err(IgnoreErrorKind::FromIoError)?;
         let node_type = NodeType::from_link(&target);
-        Node::new_node(name, node_type, meta)
+        Node::from_type_and_metadata(name, node_type, meta)
     } else {
-        Node::new_node(name, NodeType::File, meta)
+        Node::from_type_and_metadata(name, NodeType::File, meta)
     };
 
     let path = entry.into_path();
@@ -555,23 +555,23 @@ fn map_entry(
     let filetype = m.file_type();
 
     let node = if m.is_dir() {
-        Node::new_node(name, NodeType::Dir, meta)
+        Node::from_type_and_metadata(name, NodeType::Dir, meta)
     } else if m.is_symlink() {
         let target = read_link(entry.path()).map_err(IgnoreErrorKind::FromIoError)?;
         let node_type = NodeType::from_link(&target);
-        Node::new_node(name, node_type, meta)
+        Node::from_type_and_metadata(name, node_type, meta)
     } else if filetype.is_block_device() {
         let node_type = NodeType::Dev { device: m.rdev() };
-        Node::new_node(name, node_type, meta)
+        Node::from_type_and_metadata(name, node_type, meta)
     } else if filetype.is_char_device() {
         let node_type = NodeType::Chardev { device: m.rdev() };
-        Node::new_node(name, node_type, meta)
+        Node::from_type_and_metadata(name, node_type, meta)
     } else if filetype.is_fifo() {
-        Node::new_node(name, NodeType::Fifo, meta)
+        Node::from_type_and_metadata(name, NodeType::Fifo, meta)
     } else if filetype.is_socket() {
-        Node::new_node(name, NodeType::Socket, meta)
+        Node::from_type_and_metadata(name, NodeType::Socket, meta)
     } else {
-        Node::new_node(name, NodeType::File, meta)
+        Node::from_type_and_metadata(name, NodeType::File, meta)
     };
 
     let path = entry.into_path();

crates/core/src/backend/node.rs

@@ -280,7 +280,11 @@ impl Node {
     /// # Returns
     ///
     /// The created [`Node`]
-    pub fn new_node(name: &OsStr, node_type: NodeType, meta: Metadata) -> RusticResult<Self> {
+    pub fn from_type_and_metadata(
+        name: &OsStr,
+        node_type: NodeType,
+        meta: Metadata,
+    ) -> RusticResult<Self> {
         Ok(Self {
             name: escape_file_name(name)?,
             node_type,

crates/core/src/backend/stdin.rs

@@ -69,8 +69,12 @@ impl Iterator for StdinSource {
 
         Some(Ok(ReadSourceEntry {
             path: self.path.clone(),
-            node: Node::new_node(self.path.file_name()?, NodeType::File, Metadata::default())
-                .ok()?,
+            node: Node::from_type_and_metadata(
+                self.path.file_name()?,
+                NodeType::File,
+                Metadata::default(),
+            )
+            .ok()?,
             open: Some(OpenStdin()),
         }))
     }

crates/core/src/blob/tree.rs

@@ -139,7 +139,8 @@ impl Tree {
         id: Id,
         path: &Path,
     ) -> RusticResult<Node> {
-        let mut node = Node::new_node(OsStr::new(""), NodeType::Dir, Metadata::default())?;
+        let mut node =
+            Node::from_type_and_metadata(OsStr::new(""), NodeType::Dir, Metadata::default())?;
         node.subtree = Some(id);
 
         for p in path.components() {

crates/core/src/vfs.rs

@@ -384,7 +384,7 @@ impl Vfs {
                         VfsTree::Link(target) => NodeType::from_link(Path::new(target)),
                         _ => NodeType::Dir,
                     };
-                    Node::new_node(name, node_type, Metadata::default())
+                    Node::from_type_and_metadata(name, node_type, Metadata::default())
                 })
                 .collect::<RusticResult<Vec<Node>>>()?,
             VfsPath::Link(str) => {