Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interactive): Allow to view text files #1216

Merged
merged 6 commits into from
Sep 8, 2024
Merged

feat(interactive): Allow to view text files #1216

merged 6 commits into from
Sep 8, 2024

Conversation

aawsome
Copy link
Member

@aawsome aawsome commented Aug 29, 2024

Adds the possibility to view text files up to 1MiB in the interactive snapshot tree view. Note this is a quick-and-dirty implementation which could be improved better non-text-files and which could be optimized to read files of all sizes

@aawsome aawsome changed the title feat(interactive): Allow to view files feat(interactive): Allow to view text files Sep 8, 2024
@aawsome
Copy link
Member Author

aawsome commented Sep 8, 2024

@nardoor Thanks for the review, especially for finding the bug about the changeable :-)

@aawsome aawsome requested a review from nardoor September 8, 2024 14:16
Copy link
Contributor

@nardoor nardoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from a potential warning that the view action couldn't be finalized as the file isn't utf8, it lgtm.

@aawsome aawsome enabled auto-merge September 8, 2024 17:31
@aawsome aawsome added this pull request to the merge queue Sep 8, 2024
Merged via the queue into main with commit 740cb46 Sep 8, 2024
25 checks passed
@aawsome aawsome deleted the interactive-view branch September 8, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants