Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated unsoundness information in AsPrimitive documentation #188

Closed
kotauskas opened this issue Sep 22, 2020 · 1 comment · Fixed by #193
Closed

Outdated unsoundness information in AsPrimitive documentation #188

kotauskas opened this issue Sep 22, 2020 · 1 comment · Fixed by #193

Comments

@kotauskas
Copy link

The page for AsPrimitive mentions soundness holes from old versions of Rust related to floating point cast results, more specifically, #10184 and #15536. Those have now been resolved, which is why the documentation should remove mentions of those bugs or explicitly state that those have been fixed and no longer cause undefined behavior.
@cuviper
Copy link
Member

cuviper commented Sep 22, 2020

#184 updated this, but it hasn't been published in a release yet.

@cuviper cuviper linked a pull request Oct 29, 2020 that will close this issue
Release 0.2.13 #193
Merged
@bors bors bot closed this as completed in #193 Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 0.2.13 cuviper/num-traits
2 participants
@cuviper @kotauskas