Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check test the driver and adapter handle OsStrings correctly #67

Closed
xFrednet opened this issue Dec 1, 2022 · 0 comments · Fixed by #108
Closed

Check test the driver and adapter handle OsStrings correctly #67

xFrednet opened this issue Dec 1, 2022 · 0 comments · Fixed by #108
Labels
A-driver Area: Driver or something related to the internal working of a driver. A-marker-adapter Area: Adapter E-good-first-issue Participation: Good for newcomers

Comments

@xFrednet
Copy link
Member

xFrednet commented Dec 1, 2022

Lint crates are compiled by cargo-marker, the path of the build binary is passed to the adapter via environment values. The loading of these libraries should ideally use OsString to ensure that it works with whatever interesting path a user might throw at it. This requires a bit of auditing.

cargo-marker has been checked as part of #66 and should be fine. A second pair of eyes would be appreciated :)

@xFrednet xFrednet added E-good-first-issue Participation: Good for newcomers A-marker-adapter Area: Adapter A-driver Area: Driver or something related to the internal working of a driver. labels Dec 1, 2022
@bors bors bot closed this as completed in a9b5298 Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-driver Area: Driver or something related to the internal working of a driver. A-marker-adapter Area: Adapter E-good-first-issue Participation: Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant