Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming: min/max horizontal reductions. #390

Closed
gnzlbg opened this issue Mar 20, 2018 · 1 comment
Closed

Naming: min/max horizontal reductions. #390

gnzlbg opened this issue Mar 20, 2018 · 1 comment

Comments

@gnzlbg
Copy link
Contributor

gnzlbg commented Mar 20, 2018

Currently the min/max horizontal reductions are named: min and max.

That is: a.max() returns the largest element in the vector.

However, it isn't unthinkable that we might want to add vertical min/max methods some day: a.max(b) returning lane-wise min/max.

I would be more comfortable with giving the horizontal min/max reductions a different name.
@gnzlbg
Copy link
Contributor Author

gnzlbg commented Apr 11, 2018

These have been named min_element/max_element to differentiate them from the vertical min/max reductions.

@gnzlbg gnzlbg closed this as completed Apr 11, 2018
@DevJPM DevJPM mentioned this issue Oct 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gnzlbg