Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc source view: backtrace 404s #98220

Closed
jsha opened this issue Jun 18, 2022 · 5 comments
Closed

rustdoc source view: backtrace 404s #98220

jsha opened this issue Jun 18, 2022 · 5 comments
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jsha
Copy link
Contributor

jsha commented Jun 18, 2022

Steps to reproduce:

  1. Visit https://doc.rust-lang.org/std/
  2. Click "source"
  3. Open the sidebar
  4. In the sidebar, click "backtrace", then "src", then "lib.rs".

Expected result: either backtrace's lib.rs loads, or it is not listed.

Actual result: 404 (https://doc.rust-lang.org/src/std/backtrace/src/lib.rs.html)

@jsha jsha added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Jun 18, 2022
@353fc443
Copy link

Hi,

I looked into this issue and found that the files listed in the sidebar is not actually present in the backtrace directory.

It only contain tests.rs (which i think is ignored).

https://github.com/rust-lang/rust/tree/stable/library/std/src/backtrace

:)

@jsha
Copy link
Contributor Author

jsha commented Jun 18, 2022

I believe it's actually brought in as a submodule. See https://github.com/rust-lang/rust/tree/stable/library; and in a checked out rust repository, try ls library/backtrace/src/lib.rs.

@353fc443
Copy link

Then I think it is some issue with submodule .

@clubby789
Copy link
Contributor

clubby789 commented Jan 7, 2023

Testing locally, this was fixed by #106466. Rustdoc handled #[path = ../xx/yy.rs] modules inconsistently.

Now fixed on nightly - https://doc.rust-lang.org/nightly/src/std/backtrace/src/lib.rs.html

@lolbinarycat
Copy link
Contributor

triage: fixed on stable too, and it seems like there's a regression test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants