Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rustdoc crate name extraction #9696

Closed
sfackler opened this issue Oct 3, 2013 · 5 comments
Closed

Fix rustdoc crate name extraction #9696

sfackler opened this issue Oct 3, 2013 · 5 comments
Labels
P-medium Medium priority T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Milestone

Comments

@sfackler
Copy link
Member

sfackler commented Oct 3, 2013

emberian/rustdoc_ng#15 never got filed here when rustdoc-ng was pulled in.

Rustdoc currently requires #[link(name="foo")] to get the crate name, even through link attributes are being deprecated (#8523). Removing rustdoc as a separate executable entirely and moving the functionality to rustpkg doc seems like the best solution to me.

@alexcrichton
Copy link
Member

Nominating. This is a serious hindrance to "just using" rustdoc and rustpkg de-emphasizes the name of the crate in an attribute as well.

@brson
Copy link
Contributor

brson commented Oct 24, 2013

I'm skeptical about combining rustdoc and rustpkg since they are mostly independent functionality and we don't like creating monolithic super-crates.

@brson
Copy link
Contributor

brson commented Oct 24, 2013

My preference might be to make rustpkg link to rustdoc.

@emberian
Copy link
Member

They need to link to each other. rustdoc needs to know a crate's name, rustpkg needs to be able to doc a crate. Currently it is impossible to use rustdoc with rustpkg.

@emberian
Copy link
Member

emberian commented Jan 5, 2014

Fixed. They both use crate_id.

@emberian emberian closed this as completed Jan 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-medium Medium priority T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants