Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

min-type-alias-impl-trait should not accept impl trait in assoc. type binding #86731

Closed
nikomatsakis opened this issue Jun 29, 2021 · 2 comments
Closed

min-type-alias-impl-trait should not accept impl trait in assoc. type binding #86731

nikomatsakis opened this issue Jun 29, 2021 · 2 comments
Labels
F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` I-needs-decision Issue: In need of a decision. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

The following example represents an illegal use for min_type_alias_impl_trait

playground of more complete code

pub type FooImpl = impl Foo;
pub type BarImpl = impl Bar<Foo = FooImpl>;

But we are not reporting it that way.
@nikomatsakis nikomatsakis added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. F-min_type_alias_impl_trait labels Jun 29, 2021
@nikomatsakis nikomatsakis mentioned this issue Jun 29, 2021
Closed
@nikomatsakis nikomatsakis changed the title min-type-alias-impl-trait should not accept impl trait in min-type-alias-impl-trait should not accept impl trait in assoc. type binding Jun 29, 2021
@nikomatsakis nikomatsakis mentioned this issue Jun 29, 2021
Open
@oli-obk oli-obk added F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` and removed F-min_type_alias_impl_trait labels Mar 30, 2022
@oli-obk oli-obk added the I-needs-decision Issue: In need of a decision. label May 3, 2022
@oli-obk
Copy link
Contributor

oli-obk commented May 3, 2022

It seems fine to me under the full type-alias-impl-trait feature as implemented. I think we should just close this issue and keep allowing the example

@nikomatsakis
Copy link
Contributor Author

This works "as expected" now and we have tests, @oli-obk claims :)

@oli-obk oli-obk moved this from Todo to Done in type alias impl trait stabilization Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` I-needs-decision Issue: In need of a decision. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
type alias impl trait stabilization
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikomatsakis @oli-obk