Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Type aliases are bolded #86256

Closed
camelid opened this issue Jun 13, 2021 · 8 comments · Fixed by #86271
Closed

regression: Type aliases are bolded #86256

camelid opened this issue Jun 13, 2021 · 8 comments · Fixed by #86271
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. P-medium Medium priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Jun 13, 2021

It looks like a CSS rule is being applied incorrectly.

It also looks weird if you click through to the type alias's page (Visibilities).

nightly (incorrect)

image

beta (correct)

image

@camelid camelid added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. C-bug Category: This is a bug. I-prioritize Issue: Indicates that prioritization has been requested for this issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc labels Jun 13, 2021
@apiraino
Copy link
Contributor

I'm not really sure, could that be slipped in 5bd9146?

@camelid
Copy link
Member Author

camelid commented Jun 13, 2021

It turns out it was actually much more recent. The PR causing the regression was #84703, cc @GuillaumeGomez.

MCVE

pub type Foo = u32;

pub struct Bar { pub f: Foo }

Bisection

searched nightlies: from nightly-2021-05-01 to nightly-2021-06-12
regressed nightly: nightly-2021-06-04
searched commits: from dbe459d to cc77ba4
regressed commit: da86509

bisected with cargo-bisect-rustc v0.6.0

Host triple: x86_64-apple-darwin
Reproduce with:

cargo bisect-rustc --prompt --start=2021-05-01 --end=2021-06-12 -- doc --open 

@LeSeulArtichaut
Copy link
Contributor

The culprit CSS rule is here:

.impl, .method,
.type:not(.container-rustdoc), .associatedconstant,
.associatedtype {
flex-basis: 100%;
font-weight: 600;
margin-top: 16px;
margin-bottom: 10px;
position: relative;
}

It also caused #86069 which was fixed by #86078.

@GuillaumeGomez
Copy link
Member

Ah, I have missed this one. Sending a fix.

@camelid
Copy link
Member Author

camelid commented Jun 13, 2021

Assigning priority as discussed in the prioritization working group.

@rustbot label: +P-medium -I-prioritize

@rustbot rustbot added P-medium Medium priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Jun 13, 2021
@GuillaumeGomez
Copy link
Member

The fix should be merged in less than 3 hours. ;)

@camelid
Copy link
Member Author

camelid commented Jun 13, 2021

The fix should be merged in less than 3 hours. ;)

I know, but we had already agreed on a priority :)

@GuillaumeGomez
Copy link
Member

Oh I see. Thanks for taking care of that then! :)

@bors bors closed this as completed in f586d79 Jun 13, 2021
@jyn514 jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. P-medium Medium priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants