Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that hasClass is correctly used #85450

Closed
GuillaumeGomez opened this issue May 18, 2021 · 1 comment
Closed

Ensure that hasClass is correctly used #85450

GuillaumeGomez opened this issue May 18, 2021 · 1 comment
Assignees
@GuillaumeGomez
Labels
A-rustdoc-js Area: Rustdoc's JS front-end C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented May 18, 2021 •
edited
Loading

As discovered in #85438, hasClass returns false when the element doesn't exist (which is normal) but that means we have to check if the element exist beforehand sometimes too.
@GuillaumeGomez GuillaumeGomez added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-js Area: Rustdoc's JS front-end labels May 18, 2021
@GuillaumeGomez GuillaumeGomez self-assigned this May 18, 2021
@GuillaumeGomez GuillaumeGomez mentioned this issue May 19, 2021
Closed
@jsha
Copy link
Contributor

jsha commented May 22, 2021

Resolved by closing the linked PR.

@jsha jsha closed this as completed May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-rustdoc-js Area: Rustdoc's JS front-end C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add documentation for hasClass function GuillaumeGomez/rust
2 participants
@jsha @GuillaumeGomez