Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls no longer builds after rust-lang/rust#66879 #66885

Closed
rust-highfive opened this issue Nov 30, 2019 · 5 comments · Fixed by #67198
Closed

rls no longer builds after rust-lang/rust#66879 #66885

rust-highfive opened this issue Nov 30, 2019 · 5 comments · Fixed by #67198
Assignees
@Xanewok
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #66879, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @RalfJung, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @RalfJung, the PR reviewer, and nominating for compiler team prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 30, 2019
@mati865
Copy link
Contributor

mati865 commented Dec 4, 2019

I'm not sure but this is possibly blocked on fixing rustfmt: rust-lang/rustfmt#3903

@pnkfelix
Copy link
Member

pnkfelix commented Dec 5, 2019

triage: P-medium, removing nomination.

@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Dec 5, 2019
@tmandry
Copy link
Member

tmandry commented Dec 9, 2019

Ping, is anyone working on this?

From rust-lang/rustfmt#3903 (comment):

I do not think this is blocking the broken RLS as AFAIK RLS does not directly depend on rustc-ap-* crates.

@Xanewok Xanewok mentioned this issue Dec 10, 2019
Merged
@Xanewok
Copy link
Member

Xanewok commented Dec 10, 2019

Sorry for that, somehow I was sure I addressed this 😲 Just opened #67198

@tmandry
Copy link
Member

tmandry commented Dec 11, 2019

@Xanewok no worries, thanks for the quick response :)

@bors bors closed this as completed in a233302 Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xanewok Xanewok

Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update RLS and Rustfmt Xanewok/rust
5 participants
@pnkfelix @mati865 @tmandry @Xanewok @rust-highfive