Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @-boxes from the visitor #6215

Closed
brson opened this issue May 3, 2013 · 4 comments
Closed

Remove @-boxes from the visitor #6215

brson opened this issue May 3, 2013 · 4 comments
Labels
A-codegen Area: Code generation A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows

Comments

@brson
Copy link
Contributor

brson commented May 3, 2013

Using the GC in the visitor means that there are contexts where logging doesn't work correctly. It also forces tasks to use GC that otherwise wouldn't want to.

Partly blocking #3309

@brson
Copy link
Contributor Author

brson commented May 3, 2013

Nominating feature complete

@graydon
Copy link
Contributor

graydon commented May 9, 2013

accepted for backwards-compatible milestone

@emberian
Copy link
Member

emberian commented Aug 5, 2013

Visiting for triage; nothing to add

@alexcrichton
Copy link
Member

This has since been done. The visitor now primarily uses traits, and it's up to the implementors of the traits to decide whether to use @-boxes or not (as it should be).

Nice work everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area: Code generation A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Projects
None yet
Development

No branches or pull requests

4 participants