Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consts in const generics should be pretty-printed #60738

Closed
varkor opened this issue May 11, 2019 · 2 comments
Closed

Consts in const generics should be pretty-printed #60738

varkor opened this issue May 11, 2019 · 2 comments
Labels
A-const-generics Area: const generics (parameters and arguments) C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@varkor
Copy link
Member

varkor commented May 11, 2019

Often consts are debug-printed (e.g. ConstValue::Unevaluated(..)), rather than being pretty-printed. I don't have an exhaustive list of places that need to be fixed here, but I've noticed it in some errors.
@varkor varkor added A-const-generics Area: const generics (parameters and arguments) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels May 11, 2019
@varkor varkor mentioned this issue May 11, 2019
Closed
@varkor
Copy link
Member Author

varkor commented May 14, 2019

These issues may be partially addressed by #59276.

@varkor
Copy link
Member Author

varkor commented May 30, 2019

I'm going to close this, because I think #59276 has addressed most of the issues. If we encounter any more, it should be addressed by replacing the debug printing with normal printing of consts.

@varkor varkor closed this as completed May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-const-generics Area: const generics (parameters and arguments) C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@varkor