Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x.py build passing with parse error in file #58826

Closed
euclio opened this issue Mar 1, 2019 · 2 comments
Closed

x.py build passing with parse error in file #58826

euclio opened this issue Mar 1, 2019 · 2 comments
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@euclio
Copy link
Contributor

euclio commented Mar 1, 2019

Discovered while working on #58824.

Notice that travis passed for x86_64-gnu-llvm-6.0, but failed for mingw-check. It shouldn't pass -- there's a parse error. The build passes locally for me using ./x.py test --bless src/test/rustdoc-ui but ./build/x86_64-unknown-linux-gnu/stage2/bin/rustc -Z parse-only src/librustdoc/passes/collect_intra_doc_links.rs fails. I wonder if this is a bug in rustbuild or cargo?

No success in minimizing this, but I am able to consistently reproduce it.

@Centril Centril added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Mar 1, 2019
@euclio
Copy link
Contributor Author

euclio commented Mar 1, 2019

So as to not block the linked PR, I've pushed the non-working build here:

https://github.com/euclio/rust/blob/d5c59523588121cf337f2efd70afc031634770a1/src/librustdoc/passes/collect_intra_doc_links.rs#L562

Link to failed travis here.

I also am able to reproduce this on my Mac, so it's not Linux-specific.

@euclio
Copy link
Contributor Author

euclio commented Mar 8, 2019

Fixed by #58903.

@euclio euclio closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants