Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc no longer renders source #56526

Closed
Mark-Simulacrum opened this issue Dec 5, 2018 · 7 comments
Closed

rustdoc no longer renders source #56526

Mark-Simulacrum opened this issue Dec 5, 2018 · 7 comments
Labels
P-high High priority T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

For example, see https://doc.rust-lang.org/nightly/src/core/sync/atomic.rs.html#1112-1114 -- the source is blank for me. I've tried hard-refreshing but that didn't appear to help.

master -> beta promotion happened today so this may also be a regression (not sure since beta hasn't yet deployed)

cc @rust-lang/rustdoc

@Mark-Simulacrum Mark-Simulacrum added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. I-nominated P-high High priority labels Dec 5, 2018
@Walther
Copy link

Walther commented Dec 5, 2018

Seems to be a style / css issue, if I'm not mistaken, the contents are still there: scroll down far enough, and you'll see the source, below the line numbers.

screen shot 2018-12-04 at 20 38 13

@Walther
Copy link

Walther commented Dec 5, 2018

On a quick glance with inspector, toggling this value

.example-wrap {
 width:100%;
}

in rustdoc.css
looked like a quick workaround. Haven't tested if it causes any other complications

@GuillaumeGomez
Copy link
Member

There is already a PR open to fix it: #56498.

@hellow554
Copy link
Contributor

hellow554 commented Dec 6, 2018

Related: rust-lang/docs.rs#264

@QuietMisdreavus
Copy link
Member

Docs.rs has a separate issue causing its source view to act like this. It needs its own fix to make that work.

@QuietMisdreavus
Copy link
Member

Because of the timing of its merge, #56498 will appear in tomorrow's nightly, which will fix this issue.

@GuillaumeGomez
Copy link
Member

Since #56498 got merged, we can close this issue I assume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-high High priority T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants