Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change visitor code to generate code with explicit self #4255

Closed
jesse99 opened this issue Dec 22, 2012 · 2 comments
Closed

Change visitor code to generate code with explicit self #4255

jesse99 opened this issue Dec 22, 2012 · 2 comments
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Milestone

Comments

@jesse99
Copy link
Contributor

jesse99 commented Dec 22, 2012

Tried to add #[warn(deprecated_self)]; to https://github.com/jdm/rust-socket and got a bunch of warnings like:

<intrinsic>:32:21: 32:25 warning: this method form is deprecated; use an explicit `self` parameter or mark the method as static
<intrinsic>:32         fn visit_bot() -> bool;
                                    ^~~~
<intrinsic>:33:21: 33:25 warning: this method form is deprecated; use an explicit `self` parameter or mark the method as static
<intrinsic>:33         fn visit_nil() -> bool;
                                    ^~~~
<intrinsic>:34:22: 34:26 warning: this method form is deprecated; use an explicit `self` parameter or mark the method as static
<intrinsic>:34         fn visit_bool() -> bool;
                                     ^~~~

This is with 0.5

@catamorphism
Copy link
Contributor

Changed the title to better reflect what the issue is.

@pcwalton
Copy link
Contributor

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

3 participants