Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tool to verify core/std have the same API #32632

Closed
alexcrichton opened this issue Mar 31, 2016 · 5 comments
Closed

Add a tool to verify core/std have the same API #32632

alexcrichton opened this issue Mar 31, 2016 · 5 comments
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@alexcrichton
Copy link
Member

In theory core is an exact subset of libstd's API surface area. In practice there's been some bugs here and there, so we should write a tool to verify that the two are the same. We can then check it into the tree and sleep soundly at night knowing that they'll never diverge again!

@alexcrichton
Copy link
Member Author

cc @rust-lang/libs

@durka
Copy link
Contributor

durka commented Mar 31, 2016

Perhaps just running libcoretest against std?

@alexcrichton
Copy link
Member Author

Now that's not a bad idea! We could possibly do something like:

rustc src/libcoretest/lib.rs --extern core=path/to/libstd.rlib

@Mark-Simulacrum Mark-Simulacrum added T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. and removed T-tools labels May 24, 2017
@Mark-Simulacrum Mark-Simulacrum added C-feature-request Category: A feature request, i.e: not implemented / a PR. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 24, 2017
@steveklabnik
Copy link
Member

Triage: no change

there has been some discussion of eliminating the core/std distinction; if that ever comes to pass, this will end up being "fixed" by that.

@Mark-Simulacrum
Copy link
Member

Closing as a duplicate of #60479 (which has more discussion).

@Mark-Simulacrum Mark-Simulacrum closed this as not planned Won't fix, can't repro, duplicate, stale Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants