Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pub extern crate in rustc #32143

Closed
durka opened this issue Mar 9, 2016 · 2 comments
Closed

pub extern crate in rustc #32143

durka opened this issue Mar 9, 2016 · 2 comments

Comments

@durka
Copy link
Contributor

durka commented Mar 9, 2016

This was identified as a bad thing in #28486 but there are five of them in the compiler:

src/librustc/lib.rs
52:pub extern crate rustc_llvm as llvm;

src/librustc_trans/lib.rs
49:pub extern crate rustc_llvm as llvm;

src/libstd/sys/unix/net.rs
24:pub extern crate libc as netc;

src/test/auxiliary/privacy_reexport.rs
11:pub extern crate core;

src/test/rustdoc/issue-27104.rs
19:// @has - 'pub extern crate empty'
20:pub extern crate empty;

Presumably they should be cleaned up.

@srinivasreddy
Copy link
Contributor

Raised a PR - #32144 .

@mitaa
Copy link
Contributor

mitaa commented Mar 9, 2016

Is this warning actually still necessary, since it is just a "temporary fix" for an issue that has been closed (and solved?) ?

@durka durka closed this as completed Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants