Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta regression with lifetime inference #29979

Closed
Ryman opened this issue Nov 22, 2015 · 4 comments
Closed

Beta regression with lifetime inference #29979

Ryman opened this issue Nov 22, 2015 · 4 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Ryman
Copy link
Contributor

Ryman commented Nov 22, 2015

I'm unsure if this issue is specifically related to Borrow or HashMap::get but this playpen works on current stable (1.4), but fails on both beta and nightly.

The issue can be fixed with a type annotation in the simple case, as shown on playpen if you uncomment the line above the failure, so I assume failure is not intended by some change in lifetime rules. (Additionally, the error message itself doesn't help lead a user to the solution here :( )

But, I've got a more complicated manifestation which I've been unable to solve with type-hints so I think it's worth a look at: seanmonstar/unicase#6

Travis outputs for linked PR

cc @nikomatsakis @brson

@sfackler sfackler added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Nov 22, 2015
@bluss
Copy link
Member

bluss commented Nov 22, 2015

This should be the same as #28853

@arielb1
Copy link
Contributor

arielb1 commented Nov 22, 2015

@Ryman

This is a known regression that is the same as #28853. The old code compiled for dubious reasons. Due to the evil nature of find, it is unclear how to get it to compile usefully, except by aggressive use of transmute.

@arielb1 arielb1 added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 22, 2015
@Ryman
Copy link
Contributor Author

Ryman commented Nov 23, 2015

@arielb1 Okay, should we close as duplicate?

@brson
Copy link
Contributor

brson commented Nov 23, 2015

Closing per @arielb1 as dupe.

@brson brson closed this as completed Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants