Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsyntax: Consider using Names instead of most Idents in AST datastructures #28659

Closed
petrochenkov opened this issue Sep 25, 2015 · 1 comment
Closed

libsyntax: Consider using Names instead of most Idents in AST datastructures #28659

petrochenkov opened this issue Sep 25, 2015 · 1 comment
Labels
A-parser Area: The parsing of Rust source code to an AST

Comments

@petrochenkov
Copy link
Contributor

Spawned from #28642
Similar to #6993

Idents are strictly necessary for PathSegment, PatIdent (hygienic identifiers) and ExprWhile, ExprLoop, ExprBreak, ExprAgain(hygienic labels). All other data structures in AST can live with Names most of the time and convert them into Idents with empty context in rare circumstances when Ident needs to be obtained from a non-hygienic name.
@steveklabnik steveklabnik added the A-parser Area: The parsing of Rust source code to an AST label Sep 28, 2015
@petrochenkov petrochenkov mentioned this issue Aug 12, 2016
Merged
@petrochenkov
Copy link
Contributor Author

This seems to be incompatible with macros 2.0 and item hygiene plans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parser Area: The parsing of Rust source code to an AST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steveklabnik @petrochenkov