Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: consider lowering / skipping compression when x.py installing artifacts #109308

Closed
matthiaskrgr opened this issue Mar 18, 2023 · 5 comments · Fixed by #118724
Closed
Assignees
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@matthiaskrgr
Copy link
Member

matthiaskrgr commented Mar 18, 2023

Right now when doing a local x.py install, we first compress the artifacts with max compression ratio, just to immediately unpack them again when installing them to disk.
Making the compression level less aggressive or skipping it altogether can probably save 5-10 minutes on an x.py install.

@matthiaskrgr matthiaskrgr added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Mar 18, 2023
@Mark-Simulacrum
Copy link
Member

cc #109124

You probably want to use the gzip'd artifacts which are less intensely compressed.

@jyn514
Copy link
Member

jyn514 commented Mar 18, 2023

tbh it seems strange that we're compressing these at all - why not put them into an uncompressed .tar archive when using install?

@jyn514
Copy link
Member

jyn514 commented Mar 18, 2023

or even better, copy them directly from the build directory to the install directory without going through a .tar archive first.

@onur-ozkan
Copy link
Member

@rustbot claim

@onur-ozkan
Copy link
Member

onur-ozkan commented Sep 1, 2023

Skipping the compressions and archiving in favor of directly copying the artifacts seems like a reasonable solution for x install. But it requires significant changes to how we currently handle x dist/install.

I'm planning to do a comprehensive review on bootstrapping from all angles(including T-bootstrap issues) and make a roadmap for future development. To avoid conflicts(e.g, if we have improvement ideas on dist/install modules, implementing this might increase the technical debt which will require more effort from the team), I will postpone this task for now and re-prioritize it once we have organized the plans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants