Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incoming clippy breakage #2771

Closed
phansch opened this issue May 17, 2018 · 2 comments
Closed

Incoming clippy breakage #2771

phansch opened this issue May 17, 2018 · 2 comments
Labels
I-ICE Issue: Clippy panicked, giving an Internal Compilation Error (ICE) ❄️

Comments

@phansch
Copy link
Member

phansch commented May 17, 2018 •
edited
Loading

rust-lang/rust#50615 renames rustc_trans to rustc_codegen, which we use in src/driver.rs#L12
@phansch phansch added the I-ICE Issue: Clippy panicked, giving an Internal Compilation Error (ICE) ❄️ label May 17, 2018
@witchof0x20
Copy link

Would a PR for this be welcome? I wrote up this commit which is pretty much identical to rust-lang/rls#872

@oli-obk
Copy link
Contributor

oli-obk commented May 19, 2018

Fixed in #2775

@witchof0x20 someone got ahead of you. please don't hesitate to open PRs. We're very happy about any contributions! Even if something is not a full fix or impl, just open a PR, we can figure out the details afterwards

@oli-obk oli-obk closed this as completed May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-ICE Issue: Clippy panicked, giving an Internal Compilation Error (ICE) ❄️
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oli-obk @phansch @witchof0x20