Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent regex update might have break all related ui tests #11118

Closed
J-ZhengLi opened this issue Jul 7, 2023 · 2 comments
Closed

Recent regex update might have break all related ui tests #11118

J-ZhengLi opened this issue Jul 7, 2023 · 2 comments

Comments

@J-ZhengLi
Copy link
Member

Description

regex crate just recieved a 1.9.0 update, however, all test cases under regex.rs does not produce output for some reason.

I tried running TESTNAME='regex' cargo uitest on stable branch, and it fails on either windows or linux platform.
Then I manually modify Cargo.lock and set the version of regex to 1.8.4, and regex-syntax to 0.7.2, and everything works normal.
Which is kinda weird, can someone confirm this please? Should Cargo.lock be included in the future?

Version

No response

Additional Labels

No response

@y21
Copy link
Member

y21 commented Jul 7, 2023

yep, apparently the path to Regex changed and that broke the lint. It was causing CI to fail for all PRs too, however #11111 just got merged and that should have fixed this. Are you on the latest commit? (edit: oh I missed that you said "stable")

@J-ZhengLi
Copy link
Member Author

yep, apparently the path to Regex changed and that broke the lint. It was causing CI to fail for all PRs too, however #11111 just got merged and that should have fixed this. Are you on the latest commit? (edit: oh I missed that you said "stable")

ahhh~ glad to know it has already been fixed, but I guess I have to manually set regex version each time until that commit made it to the next stable 🤦‍♂️, thank you though, closing this right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants