Skip to content
This repository has been archived by the owner on Nov 26, 2020. It is now read-only.

Promotion should use a consistent date and time #50

Closed
aidanhs opened this issue Jun 19, 2018 · 3 comments
Closed

Promotion should use a consistent date and time #50

aidanhs opened this issue Jun 19, 2018 · 3 comments

Comments

@aidanhs
Copy link
Member

aidanhs commented Jun 19, 2018

The sign-and-hash invocation on x.py calls date, but so does RCS on startup. If these straddle a new day, bad things happen.

One big hammer is to use faketime to fix the time at the top level and make every date command return the same value.

@aidanhs
Copy link
Member Author

aidanhs commented Jun 19, 2018

cc @Mark-Simulacrum

@aidanhs aidanhs changed the title RCS should use a consistent date and time Promotion should use a consistent date and time Jun 19, 2018
@Mark-Simulacrum
Copy link
Member

I think perhaps the better way to fix this is to pull https://github.com/rust-lang/rust/tree/master/src/tools/build-manifest into this repo and then depend on it directly.

This will simplify x.py I think since we can then remove some configuration and a few other things -- HashSign is a really odd step anyway as-is today.

It's not completely trivial since there's some version ready x.py knows of but should be feasible and a good step to take.

@pietroalbini
Copy link
Member

This is fixed by the new promote-release, since it passes the date it's using directly to build-manifest.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants