You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The commit hash is accurate to the submodule under rust, so that's fine.
The date is the build date, rather than the commit date. I included cargo above as an example where that's different, as the build is current but the submodule is not updated every day.
The "dev" string looks like it comes from lack of RUST_ANALYZER_CHANNEL in the build script. It's not a big deal, except it also triggers poke_rust_analyzer_developer, which we probably don't want in official builds. Maybe rustbuild should set this to "preview" for now, and eventually follow rustc's own channel names.
So to clarify, ideally for the rust-up component build we should provide the following format rust-analyzer <toolchain-version>-<toolchain-channel> (<commit-hash> <commit-date>)?
Yes not poking is definitely somethign we'd want. For our dev builds we don't want to show something like 1.63.0-nightly anyways since these builds aren't really tied to a rust release, so for dev builds we can use some other string here to signal that.
This is minor, but I noticed the version output in
rust-analyzer-preview
builds fromrustup
is inconsistent with other tools:RUST_ANALYZER_CHANNEL
in the build script. It's not a big deal, except it also triggerspoke_rust_analyzer_developer
, which we probably don't want in official builds. Maybe rustbuild should set this to "preview" for now, and eventually follow rustc's own channel names.This may be something to track in #4224.
The text was updated successfully, but these errors were encountered: