Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for miri_get_backtrace with flags == 0 #4149

Closed
RalfJung opened this issue Jan 24, 2025 · 2 comments · Fixed by #4172
Closed

Remove support for miri_get_backtrace with flags == 0 #4149

RalfJung opened this issue Jan 24, 2025 · 2 comments · Fixed by #4172
Labels
A-shims Area: This affects the external function shims C-cleanup Category: cleaning up our code C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement

Comments

@RalfJung
Copy link
Member

The main user here is the backtrace crate and it has used the v1 protocol for a while now, so we can remove support for the old protocol.

@tiif
Copy link
Contributor

tiif commented Jan 25, 2025

I'd probably get to this soon, but in case someone wants to pick it up, there are more instructions here. #4122 (comment)

@rustbot label +C-cleanup +C-enhancement

@rustbot rustbot added C-cleanup Category: cleaning up our code C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement labels Jan 25, 2025
@RalfJung RalfJung added the A-shims Area: This affects the external function shims label Feb 2, 2025
@RalfJung
Copy link
Member Author

RalfJung commented Feb 2, 2025

#4172 takes care of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-shims Area: This affects the external function shims C-cleanup Category: cleaning up our code C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants