Mergehead foreach #707
Merged
Mergehead foreach #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extrawurst
force-pushed
the
mergehead_foreach
branch
from
4619405 to
513a8c9
Compare
|
proof of concept usage of it here: gitui-org/gitui#697 including unitest. (actually my crate |
src/merge.rs
Outdated
| pub callback: &'a mut MergeheadForeachCb<'a>, | ||
| } | ||
|
|
||
| pub extern "C" fn mergehead_foreach_cb(oid: *const raw::git_oid, payload: *mut c_void) -> c_int { |
There was a problem hiding this comment.
Could these definitions be located in repo.rs since they're only used from there?
There was a problem hiding this comment.
sure I hesitated to do that before because right now nothing like this was in repo.rs but this gives us the added benefit of being able to mark a bunch more stuff non-pub 👍
|
@alexcrichton moved stuff over (see comment) |
extrawurst
force-pushed
the
mergehead_foreach
branch
from
1d31e23 to
74da401
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #705
note that I did not add a test, since I did not even find one for
mergein the first place to base this off. let me know if that's fine. the method is tested ingituithough :)