-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --emit=thin-link-bitcode
to enable distributed ThinLTO users
#735
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed. Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:
Concerns can be lifted with:
See documentation at https://forge.rust-lang.org cc @rust-lang/compiler @rust-lang/compiler-contributors |
-Zemit-thin-lto-index=<path>
to enable distributed ThinLTO users--emit=thin-link-bitcode
to enable distributed ThinLTO users
@rustbot second |
Why is the Zulip stream empty? |
https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/Add.20.60--emit.3Dthin-link-bitcode.60.20to.20enable.20.E2.80.A6.20compiler-team.23735 is the correct stream. This MCP was renamed, but triagebot doesn't change the link in it's comment. |
@rustbot label -final-comment-period +major-change-accepted |
Proposal
Clang supports distributed ThinLTO which is used by bazel and buck2 for C++ to support ThinLTO for extremely large programs. In order to make Rust a full participant of such ecosystems, we need to support emitting the "ThinLTO Index" file during codegen so that the pre-link
indexing step can operate on Rust-originated object files identically to C/C++ ones.
I expect we'd want to come back and try to stabilize this only after doing work to make use of non-rustc linkers supported, which is on our backlog to discuss but not something we can do today.
I have a working proof of concept of this MCP as a patch on my fork of rust-lang/rust. The new format is guarded by requiring users to specify
-Zunstable-options
.Mentors or Reviewers
If you have a reviewer or mentor in mind for this work, mention them here. You can put your own name here if you are planning to mentor the work.
Process
The main points of the Major Change Process are as follows:
can second by writing
@rustbot second
.proposing a new public-facing feature, such as a
-C flag
, then fullteam check-off is required.
@rfcbot fcp merge
on either the MCP or the PR.
objections are raised after 10 days, the MCP is considered approved.
You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
The text was updated successfully, but these errors were encountered: