Skip to content

Commit 9b91744

Browse files
authored
Fix compilation on macOS using clang and fix compilation using zig-cc (#1364)
* Fix compilation on macOS using clang and fix zig-cc * Reenable test detecting the regression * Fix fmt in tool.rs * Add comment
1 parent a8c9dc0 commit 9b91744

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/tool.rs

+2-4
Original file line numberDiff line numberDiff line change
@@ -428,10 +428,8 @@ impl Tool {
428428

429429
/// Supports using `--` delimiter to separate arguments and path to source files.
430430
pub(crate) fn supports_path_delimiter(&self) -> bool {
431-
matches!(
432-
self.family,
433-
ToolFamily::Clang { .. } | ToolFamily::Msvc { clang_cl: true }
434-
) && !self.cuda
431+
// homebrew clang and zig-cc does not support this while stock version does
432+
matches!(self.family, ToolFamily::Msvc { clang_cl: true }) && !self.cuda
435433
}
436434
}
437435

tests/test.rs

-2
Original file line numberDiff line numberDiff line change
@@ -405,8 +405,6 @@ fn gnu_static() {
405405
}
406406

407407
#[test]
408-
// on macOS, cc/gcc is link to apple clang
409-
#[cfg_attr(target_os = "macos", ignore)]
410408
fn gnu_no_dash_dash() {
411409
let test = Test::gnu();
412410
test.gcc().file("foo.c").compile("foo");

0 commit comments

Comments
 (0)