Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include "stage" of dependency compilation #7265

Open
Mark-Simulacrum opened this issue Aug 19, 2019 · 3 comments
Open

Include "stage" of dependency compilation #7265

Mark-Simulacrum opened this issue Aug 19, 2019 · 3 comments
Labels
A-console-output Area: Terminal output, colors, progress bar, etc. S-needs-team-input Status: Needs input from team on whether/how to proceed.

Comments

@Mark-Simulacrum
Copy link
Member

Particularly in rust-lang/rust, it might be a bit confusing to see rustc_mir finishing before librustc (for example) so it'd be great to include e.g. (codegen) after the name of the crate, similar to how I believe we do so today for build scripts. Not sure if we have the relevant information in the place the progress bar is generated though

cc @eddyb who suggested this

@eddyb
Copy link
Member

eddyb commented Aug 20, 2019

It would also be cool to have as an indicator for when the "check-like" part of the compiler is over, and maybe could be used to visually spot crates that take a disproportionate amount of time in either "half" of the compilation (before spending profiling efforts on any one crate).

@epage
Copy link
Contributor

epage commented Nov 2, 2023

It would also be cool to have as an indicator for when the "check-like" part of the compiler is over, and maybe could be used to visually spot crates that take a disproportionate amount of time in either "half" of the compilation (before spending profiling efforts on any one crate).

Since this was created, we added --timings flag which reveals the split between the two sides of compilation.

@epage
Copy link
Contributor

epage commented Nov 2, 2023

btw I recommend people look at rust-lang/rust#24335 for more context.

@epage epage added the S-triage Status: This issue is waiting on initial triage. label Nov 2, 2023
@ehuss ehuss added S-needs-team-input Status: Needs input from team on whether/how to proceed. and removed S-triage Status: This issue is waiting on initial triage. labels Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-console-output Area: Terminal output, colors, progress bar, etc. S-needs-team-input Status: Needs input from team on whether/how to proceed.
Projects
None yet
Development

No branches or pull requests

4 participants